-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Luau language #6612
Add Luau language #6612
Conversation
Hey! I'd like to ask if a CI could be ran for this, as I wasn't able to check it myself under the fork. |
I strongly support including support for Luau, which for context is an open-source Lua 5.1 fork, with many backward-compatible features (and therefore syntax) changes built onto it over the years. With that being said, I do think it's worth noting that Vector3 (or any other Roblox types/globals) probably shouldn't be included in this. Standalone Luau has no built-in Vector3 type or globals such as game, this seems largely out of scope. |
I'll be going through to fix up my commits with your suggested changes, thank you! |
I will say that it seems the larger scope of usage of Luau is under the Roblox platform. |
I agree with this, better have them just in case. |
Resolved here, thank you for your contribution! |
I do hate to add to the color debate, but neither of those colors is correct for the logo. The logo uses #00A2FF: |
Haha, thank you for pointing that out, I'll write up a commit later today to resolve that. 👍 |
Resolved here, thank you for your contribution! |
Seems we'll have to make some changes with the grammar. I'll try to submit a few PRs later this week to resolve it. |
Is there anything else that still needs changing? 🤔 |
Yes. All the submodule updates need to be reverted. We only need the files for this language updated. |
Ight bet, Im on a codespace rn fixing. |
Enhancement: Replace the signal sample.
@robloxiandemo If you're looking for more samples, I have a project, rusty-luau, which uses a lot of luau-specific features (such as types), consider that! |
Most of those examples still seem to showcase relatively advanced type features that I don't think represent the bulk of the language, Luau is an extremely useful scripting language, not just on the Roblox platform, but also for general purpose programming with the Lune runtime. It's an amazing replacement for bash/powershell scripts, python, and other high level dynamically typed scripting languages--without needing any of the baggage to install or run. Imho, Luau excels in its simplicity, ease of use, and performance. If possible, I'd like to contribute some simple, general-purpose script examples that demonstrate this side of the language but still differentiate it from Lua 5.1. |
I'll look over them and update each, though I've done it so many times already, 😅 |
Feel free to, just make sure to mention me somewhere along with the example and any related real-world usage, been finding it a tad bit difficult to find outside of Roblox examples without there just being comment spam (or having far too many lines). |
@lildude Sorry for pinging again, but any updates? Or, are there still changes that need to be made..? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
|
Description
Resolving this issue, this PR aims to finally add Luau support to the platform.
Checklist:
#14a5ff