Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roc Language #6633

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Add Roc Language #6633

merged 2 commits into from
Mar 8, 2024

Conversation

ryanb
Copy link
Contributor

@ryanb ryanb commented Dec 12, 2023

This adds syntax grammar for Roc, an up and coming functional language.

@lildude It would be amazing to get this in before 7.28.0 is deployed tomorrow. A lot of us are doing Advent of Code with Roc this year and would really appreciate some syntax highlighting.

Checklist:

@ryanb ryanb requested a review from a team as a code owner December 12, 2023 05:37
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can get this in by 11am UTC, it'll make it, but we really need real-world usage samples. These are contrived examples from the language creator, not real-world examples of in-the-wild real usage.

@ryanb ryanb force-pushed the roc branch 2 times, most recently from ae4615d to 30eb802 Compare December 12, 2023 17:55
@ryanb
Copy link
Contributor Author

ryanb commented Dec 12, 2023

@lildude I updated the samples with real-world code and rebased off master. Let me know if you need anything else.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm going to go the other way and ask you to please replace the large samples (those suppressed in the diff by default) with smaller ones 😁

@ryanb
Copy link
Contributor Author

ryanb commented Dec 20, 2023

@lildude do the samples need to be complete and compile on their own, or can they be snippets of a larger file or library?

@ryanb ryanb mentioned this pull request Dec 20, 2023
@lildude
Copy link
Member

lildude commented Dec 20, 2023

They need to be real world examples… we want samples that demonstrate how people really use the language, not contrived hogwash. We don't care if they compile or not as all we're doing is using them to train the classified.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your tests are failing because you've got samples in a sub-directory of the Roc directory. All samples must be directly in the language named directory.

@ryanb
Copy link
Contributor Author

ryanb commented Jan 10, 2024

@lildude I updated the samples to match the requirements. Let me know if there are any other issues.

@faldor20
Copy link

@ryanb @lildude Would it be better to use a tree-sitter grammar? This one is complete and i suspect would provide better highlighting than a textmate style one: https://github.com/faldor20/tree-sitter-roc

@lildude
Copy link
Member

lildude commented Jan 30, 2024

@ryanb @lildude Would it be better to use a tree-sitter grammar? This one is complete and i suspect would provide better highlighting than a textmate style one: https://github.com/faldor20/tree-sitter-roc

Nope as linguist has no control over the use of tree-sitter grammars as this is entirely up to the team that maintains the highlighting engine as mentioned previously in #6073. As with the same question in #6689 (comment) this is not likely to happen any time soon given the low usage of this language.

@faldor20
Copy link

Ahh, thanks for clarifying, that's a shame. I'll raise this again sometime in the next decade if roc achieves some level of success 😅

@ryanb
Copy link
Contributor Author

ryanb commented Feb 15, 2024

@lildude any update on the status of this? Do you need anything else from me?

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Mar 8, 2024
Merged via the queue into github-linguist:master with commit 9cc7577 Mar 8, 2024
5 checks passed
@ryanb
Copy link
Contributor Author

ryanb commented Mar 8, 2024

Thanks for merging! Looking forward to seeing it live.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants