Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SurrealQL language #6641

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add SurrealQL language #6641

wants to merge 3 commits into from

Conversation

kearfy
Copy link

@kearfy kearfy commented Dec 19, 2023

Implements grammar for SurrealDB's query language, SurrealQL.

Description

Adds grammar for the SurrealQL language

Checklist:

@kearfy kearfy requested a review from a team as a code owner December 19, 2023 08:48
@kearfy
Copy link
Author

kearfy commented Dec 20, 2023

Hi @lildude, I noticed you added the "Pending Popularity" label to the PR.

I previously figured we met that requirement as we there are over 500 SurrealQL files on GitHub, excluding possible inline SurrealQL queries. The PR template mentions that a language needs to be used across hundreds of repositories on GitHub. I added another link to the PR which shows that there are over 500 repositories related to surql/surrealql/surrealdb.

Could you possibly clarify these requirements? Thank you! 😃

lib/linguist/languages.yml Outdated Show resolved Hide resolved
Co-authored-by: Colin Seymour <colin@github.com>
@kearfy kearfy requested a review from lildude December 21, 2023 10:10
@lildude
Copy link
Member

lildude commented Dec 21, 2023

I previously figured we met that requirement as we there are over 500 SurrealQL files on GitHub, excluding possible inline SurrealQL queries.

Our current assessment guidelines are detailed in #5756 (this is linked in the CONTRIBUTING.md doc too). Your query also doesn't exclude forks. Doing so brings things down to 292 files.

I did a very quick check for 2000 files as I assumed a repo would have multiple .surql files.

@github-linguist github-linguist deleted a comment from abidulapl Jan 30, 2024
@lildude lildude changed the title Add SurrealQL grammar Add SurrealQL language Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants