Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate vscode-vba-json to bait-lang #6677

Closed
wants to merge 1 commit into from
Closed

chore: migrate vscode-vba-json to bait-lang #6677

wants to merge 1 commit into from

Conversation

serkonda7
Copy link
Contributor

Description

I have transfered the vscode-vba-json repo and update all the references/submodule here

Checklist:

  • I am adding a new extension to a language.

    • The new extension is used in hundreds of repositories on github.com
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am adding a new language.

    • The extension of the new language is used in hundreds of repositories on github.com.
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a syntax highlighting grammar: [URL to grammar repo]
    • I have added a color
      • Hex value: #RRGGBB
      • Rationale:
    • I have updated the heuristics to distinguish my language from others using the same extension.
  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • [URL to public discussion]
      • [Optional: URL to official branding guidelines for the language]

@serkonda7 serkonda7 requested a review from a team as a code owner January 14, 2024 10:43
@lildude
Copy link
Member

lildude commented Jan 14, 2024

🤔 why not just use the grammar you maintain directly?

@serkonda7
Copy link
Contributor Author

🤔 why not just use the grammar you maintain directly?

Because it's written in yaml which is not supported by linguist

@lildude
Copy link
Member

lildude commented Jan 15, 2024

Because it's written in yaml which is not supported by linguist

I'm not sure why you think this. Yaml is definitely supported, as is xml (plist) and cson. Many grammars use yaml without issues. The compiler converts all grammars to json so you don't need to 🙂

@serkonda7
Copy link
Contributor Author

Might have overlooked it when originally adding it. Will make a new PR.

@serkonda7 serkonda7 closed this Jan 15, 2024
@serkonda7 serkonda7 mentioned this pull request Jan 15, 2024
1 task
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants