Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend justfile file detection #6795

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

mkatychev
Copy link
Contributor

@mkatychev mkatychev commented Apr 12, 2024

Description

Extend justfile filetype detection

As explained on the just repo quickstart:

The search for a justfile is case insensitive, so any case, like Justfile, JUSTFILE, or JuStFiLe, will work. just will also look for files with the name .justfile, in case you'd like to hide a justfile.

the ftdetect in the sactioned justfile vim plugin defines the full globmatch:
https://github.com/IndianBoy42/tree-sitter-just/blob/main/ftdetect/just.vim

Checklist:

  • I am adding a new extension to a language.

@mkatychev mkatychev requested a review from a team as a code owner April 12, 2024 15:47
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your sample is in the wrong place.

@mkatychev
Copy link
Contributor Author

mkatychev commented Jun 6, 2024

I'm guessing I need to move it up a directory? https://github.com/github-linguist/linguist/blob/master/CONTRIBUTING.md I looked through the Contribution guidelines and I'm actually not sure what samples/<lang>/filenames/ is for.

EDIT: ran bundle exec rake && bundle exec rake test locally and passed.

@lildude
Copy link
Member

lildude commented Jun 6, 2024

I looked through the Contribution guidelines and I'm actually not sure what samples/<lang>/filenames/ is for.

This is for samples of explicitly named files added to the filenames section of a language.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Jun 7, 2024
Merged via the queue into github-linguist:master with commit 2723b1f Jun 7, 2024
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants