Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --tree-size arg should always be an Integer #6826

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

issyl0
Copy link
Collaborator

@issyl0 issyl0 commented May 14, 2024

Description

  • Otherwise we can't >= tree_size further along in the chain.
  • I tested this change by editing the local vendored files and it worked. This is hopefully my final change here. 😳
RepositoryLanguageAnalysisDependencyTest#test__includes_files_in_language__true_if_the_repo_contains_files_written_in_a_given_language_L90:
GitRPC::Error: git-linguist failed: wrong argument type String (expected Integer)
/workspaces/github/vendor/gems/3.3.1/ruby/3.3.0/gems/github-linguist-7.29.0.2.g32ae1b425/lib/linguist/repository.rb:137:in `count_recursive'

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

- Otherwise we can't `>= tree_size` further along in the chain.
@issyl0 issyl0 requested a review from a team as a code owner May 14, 2024 14:52
@lildude lildude added this pull request to the merge queue May 14, 2024
Merged via the queue into master with commit d9b3140 May 14, 2024
8 checks passed
@lildude lildude deleted the tree-size-always-int branch May 14, 2024 15:17
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants