Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Just grammar #6985

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

nefrob
Copy link
Contributor

@nefrob nefrob commented Aug 11, 2024

Description

Update just language grammar to use maintained https://github.com/nefrob/vscode-just. This has been updated as the suggested vscode extension by the just language repo here: https://github.com/casey/just?tab=readme-ov-file#visual-studio-code.

Checklist:

@nefrob nefrob requested a review from a team as a code owner August 11, 2024 13:52
@lildude
Copy link
Member

lildude commented Aug 12, 2024

🤔 Did you use the script/add-grammar script to replace the grammar?

@nefrob
Copy link
Contributor Author

nefrob commented Aug 12, 2024

🤔 Did you use the script/add-grammar script to replace the grammar?

@lildude I tried doing

script/add-grammar --replace vscode-just https://github.com/nefrob/vscode-just

per the contributing guidelines and it failed to find the submodule. I then did

script/add-grammar --replace vendor/grammars/vscode-just https://github.com/nefrob/vscode-just

but it deleted all the license files and readme entries for other languages, and failed to update the license file for vscode-just.

Screenshot 2024-08-12 at 9 00 19 AM

So I opted to try and manually edit the same files the script seemed to be modifying. Is there a different way to do this?

@lildude
Copy link
Member

lildude commented Aug 12, 2024

@lildude I tired doing

script/add-grammar --replace vscode-just https://github.com/nefrob/vscode-just

Can you please provide the output from this. This is the correct command so should work. The script hasn't been touched in a while so it's possible some sort of Git change has caught us off guard.

@lildude
Copy link
Member

lildude commented Aug 12, 2024

Ooo, I think I might have hit the issue in as much as I don't get an error, but it doesn't switch the grammar either. Looks like something is caching somewhere. Lemme dig into it.

@lildude
Copy link
Member

lildude commented Aug 12, 2024

Got it. For some reason the .git/modules/vendor/grammars/vscode-just directory isn't being removed. I'm not sure why but there's no harm manually removing it. I'll update the script and also push the update of the grammar to this PR.

@lildude lildude changed the title Replace vscode-just grammar repo Replace vscode-just grammar Aug 12, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@nefrob
Copy link
Contributor Author

nefrob commented Aug 12, 2024

@lildude thanks for the assist!

@lildude lildude changed the title Replace vscode-just grammar Replace just grammar Aug 13, 2024
@Alhadis Alhadis changed the title Replace just grammar Replace Just grammar Aug 14, 2024
@lildude lildude added this pull request to the merge queue Aug 29, 2024
Merged via the queue into github-linguist:master with commit 48b3af8 Aug 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants