-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Just grammar #6985
Replace Just grammar #6985
Conversation
🤔 Did you use the |
@lildude I tried doing
per the contributing guidelines and it failed to find the submodule. I then did
but it deleted all the license files and readme entries for other languages, and failed to update the license file for So I opted to try and manually edit the same files the script seemed to be modifying. Is there a different way to do this? |
Can you please provide the output from this. This is the correct command so should work. The script hasn't been touched in a while so it's possible some sort of Git change has caught us off guard. |
This reverts commit c756098.
Ooo, I think I might have hit the issue in as much as I don't get an error, but it doesn't switch the grammar either. Looks like something is caching somewhere. Lemme dig into it. |
Got it. For some reason the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
@lildude thanks for the assist! |
Description
Update just language grammar to use maintained https://github.com/nefrob/vscode-just. This has been updated as the suggested vscode extension by the just language repo here: https://github.com/casey/just?tab=readme-ov-file#visual-studio-code.
Checklist: