Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ccm, .cxxm, .c++m extensions for C++ #7007

Closed
wants to merge 1 commit into from

Conversation

rdong8
Copy link

@rdong8 rdong8 commented Aug 22, 2024

Adding the C++ module file extensions .c++m , .ccm, .cxxm to follow CMake's lead. Also made the extension list for C++ in ASCII alphabetical order (moved .cpp extension).

Description

Checklist:

@rdong8 rdong8 requested a review from a team as a code owner August 22, 2024 06:54
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment. Additionally, I think this PR is very very premature with none of the extensions being anywhere near meeting our usage requirements (referenced in the CONTRIBUTING.md file too).

As such, I'm going to mark this as needing changes and close this PR.

Feel free to open a new PR when usage has grown to close to meeting our requirements. You'll probably want to do this in multiple PRs so one extension doesn't hold up others. For example, all the indexed .c++m files are owned by two users so that alone would block this PR assuming all the other extensions met our requirements.

Until then, users can use an override to mark the files as C++.

@@ -772,12 +772,15 @@ C++:
aliases:
- cpp
extensions:
- ".cpp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed the comment right at the top of this file:

# extensions - An Array of associated extensions (the first one is
# considered the primary extension, the others should be
# listed alphabetically)

If .c++ is now considered the primary extension for the language, then this change is fine, but if it's not (which I suspect is the case) .cpp needs to remain the first extension in the list.

@lildude lildude closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants