Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OMNeT++ MSG language #7023

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Add OMNeT++ MSG language #7023

merged 5 commits into from
Nov 26, 2024

Conversation

adamgeorge309
Copy link
Contributor

@adamgeorge309 adamgeorge309 commented Aug 30, 2024

This adds the OMNeT++ MSG language.

Description

MSG (extension .msg) is a DSL for the OMNeT++ network simulator. It is used by model frameworks for OMNeT++, such as the INET framework, Simu5G, Veins, etc. We are the team that develops OMNeT++ and the INET Framework and we have created a TextMate grammar for this language.

Checklist:

@adamgeorge309 adamgeorge309 requested a review from a team as a code owner August 30, 2024 13:20
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very generic extension which matches way more files than your limited search which means they'll all be identified as this language.

As such, you'll need to add this extension to the generic.yml and add a very precise heuristic that only matches files for this language.

@adamgeorge309 adamgeorge309 force-pushed the omnetpp-msg branch 2 times, most recently from 8e7201b to 1ab883e Compare September 3, 2024 12:03
@adamgeorge309
Copy link
Contributor Author

I did the heuristics. Thanks.

lildude
lildude previously approved these changes Nov 25, 2024
@lildude
Copy link
Member

lildude commented Nov 25, 2024

Please merge main into your branch so CI can run. I'd normally do it but as your PR comes from an org-owned fork, permission can't be granted to me.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are legit failures:

  1) Failure:
TestPedantic#test_heuristics_tests_are_exhaustive [test/test_pedantic.rb:62]:
Extension .msg has no test in test_heuristics.rb

We need a test for this heuristic.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove samples/omnetpp-msg/Ieee80211Frame.msg as it's too large and unnecessary as there three other files.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Thanks for addressing those issues. 🙇

@lildude lildude added this pull request to the merge queue Nov 26, 2024
Merged via the queue into github-linguist:main with commit 466ed99 Nov 26, 2024
5 checks passed
@adamgeorge309
Copy link
Contributor Author

Thanks

@adamgeorge309 adamgeorge309 deleted the omnetpp-msg branch November 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants