Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CSS colour to rebeccapurple #7136

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

DecimalTurn
Copy link
Contributor

@DecimalTurn DecimalTurn commented Nov 23, 2024

Description

This PR changes the CSS color to be in line with the new CSS logo that was recently adopted.
The discussion related to the change took place in a GitHub issue (see link below) and the new color got almost 500 🎉, so the consensus is there.

Also, the change remains minor since this is a change from a shade of purple to another. However, for people that know about the meaning of rebeccapurple, it's a nice touch.

Current: #563d7c
Suggested: #663399

Fixes #7132

Checklist:

@DecimalTurn DecimalTurn requested a review from a team as a code owner November 23, 2024 00:03
@Alhadis Alhadis changed the title Change CSS color Change CSS colour to rebeccapurple Nov 23, 2024
@Alhadis
Copy link
Collaborator

Alhadis commented Nov 23, 2024

@lildude Community consensus checks out. Also, the colour change itself is scarcely noticeable (at least to my deuteranopic eyes…)

@lorypelli
Copy link

I hope this PR gets merged, that color has an important meaning that is really touching...🥹

@lorypelli
Copy link

lorypelli commented Nov 24, 2024

@lildude Community consensus checks out. Also, the colour change itself is scarcely noticeable (at least to my deuteranopic eyes…)

I think that changing it for the meaning of the color is more important than the fact that is not noticeable

@lildude lildude added this pull request to the merge queue Nov 25, 2024
Merged via the queue into github-linguist:main with commit 4eb3edd Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change css color
4 participants