Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file not used with "gren release", but works with "gren changelog" #110

Closed
ebousse opened this issue Oct 20, 2017 · 3 comments
Assignees
Labels

Comments

@ebousse
Copy link

ebousse commented Oct 20, 2017

To avoid having to always write the option --data-source=commits, I have created a configuration file called .grenrc.json with this content:

{
    "dataSource": "commits"
}

Then in the same folder I try to do a github release, and we see that it only searches for issues, not commits, therefore creating a release with 0 issues (because there is none):

$ gren release --override             

🤖  - Generate release notes:
===================================

Getting the list of releases : ...... (0.53 secs)
1 releases found

Getting tags : .... (0.35 secs)
Tags found: 2.4.0

Getting the tag dates ranges : .... (0.32 secs)
Creating the body blocks from releases:

Getting all closed issues : ...... (0.54 secs)
2.4.0 has 0 issues found	

Updating latest release : .... (0.34 secs)

2.4.0 has been successfully updated!

But if I do a git changelog, it does use the configuration file, because it correctly creates the list of commits in CHANGELOG.md.

Am I missing something?

thanks for your tool!

@alexcanessa alexcanessa self-assigned this Oct 20, 2017
@alexcanessa
Copy link
Member

@ebousse mmh.. 😕 let me investigate this and I'll come back to you 👍

@ebousse
Copy link
Author

ebousse commented Nov 3, 2017

thanks! I'll give it a try ASAP

@alexcanessa
Copy link
Member

@ebousse brilliant, thanks. Let me know.

@alexcanessa alexcanessa added this to the Release 0.13.1 milestone Dec 6, 2017
@alexcanessa alexcanessa added the bug label Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants