Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration file options being overwritten #113

Merged
merged 2 commits into from
Nov 2, 2017

Conversation

alexcanessa
Copy link
Member

Program.js was using its defaults as properties passed, which then overwrote the configuration file.

Fixes #110

@codecov-io
Copy link

codecov-io commented Nov 2, 2017

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files           7        7           
  Lines         293      293           
=======================================
  Hits          253      253           
  Misses         40       40
Impacted Files Coverage Δ
lib/src/Program.js 82.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53558f5...584d713. Read the comment docs.

@alexcanessa alexcanessa merged commit 5800bf4 into master Nov 2, 2017
@alexcanessa alexcanessa deleted the fix-config-read branch November 2, 2017 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants