Pass issue bodies and PR base/head branches into templating method #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 84.05% 38.26% -45.8%
==========================================
Files 7 7
Lines 345 345
==========================================
- Hits 290 132 -158
- Misses 55 213 +158
Continue to review full report at Codecov.
|
alexcanessa
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131, closes #161.
Since we're using
listPullRequestsfor PRs now, we can pull the PR base/head directly fromissue.As noted in #161, it would be nice to pass the full object along, at least if the config provides a custom templating function, but I'm keeping the scope small for this.