Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eslint-config-github #31

Merged
merged 8 commits into from
May 28, 2020
Merged

Upgrade eslint-config-github #31

merged 8 commits into from
May 28, 2020

Conversation

muan
Copy link
Contributor

@muan muan commented May 22, 2020 •
edited
Loading

@muan muan requested a review from koddsson May 22, 2020 21:35
@muan muan requested a review from a team May 26, 2020 16:45
@muan muan marked this pull request as ready for review May 26, 2020 16:45
@muan muan mentioned this pull request May 26, 2020
Merged
muan added 2 commits May 27, 2020 15:20
@muan
Set autocrlf to false to avoid test changing file content on checkout
8c1e1a4 
In development, we should rely on Prettier to guide people to
doing the right thing
@muan
Fix typo
7b01d5e
dgraham
dgraham approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@dgraham dgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clipboard copy doesn't contain any platform specific code so we can test only on ubuntu-latest to simplify the testing setup and avoid flaky tests.

@muan muan merged commit ba705d4 into master May 28, 2020
@muan muan deleted the eslint branch May 28, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgraham dgraham dgraham approved these changes

@koddsson koddsson Awaiting requested review from koddsson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muan @dgraham