Test only unsetting DYLD_INSERT_BINARIES

github · Aug 14, 2024 · 360bbc2 · 360bbc2
1 parent 4e34dbb
commit 360bbc2
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 16 deletions.
diff --git a/lib/environment.js b/lib/environment.js
diff --git a/lib/environment.js.map b/lib/environment.js.map
diff --git a/lib/tracer-config.js b/lib/tracer-config.js
diff --git a/lib/tracer-config.js.map b/lib/tracer-config.js.map
diff --git a/src/environment.ts b/src/environment.ts
@@ -26,6 +26,8 @@ export enum EnvVar {
    */
   DISABLE_DUPLICATE_LOCATION_FIX = "CODEQL_ACTION_DISABLE_DUPLICATE_LOCATION_FIX",
 
+  DYLD_INSERT_BINARIES = "DYLD_INSERT_BINARIES",
+
   /**
    * Whether the CodeQL Action is using its own deprecated and non-standard way of scanning for
    * multiple languages.

diff --git a/src/tracer-config.ts b/src/tracer-config.ts
@@ -7,6 +7,7 @@ import { isTracedLanguage } from "./languages";
 import { Logger } from "./logging";
 import { ToolsFeature } from "./tools-features";
 import { BuildMode } from "./util";
+import { EnvVar } from "./environment";
 
 export type TracerConfig = {
   env: { [key: string]: string };
@@ -136,12 +137,14 @@ export async function getCombinedTracerConfig(
  * other system calls in this process.
  */
 export function unsetTracerEnvVarsForCurrentProcess(): void {
-  const tracerEnvVarNames: string[] = JSON.parse(
-    process.env["CODEQL_ACTION_TRACER_ENV_VAR_NAMES"] ?? "null",
-  );
-  if (tracerEnvVarNames !== null) {
-    for (const envVar of tracerEnvVarNames) {
-      delete process.env[envVar];
-    }
-  }
+  // const tracerEnvVarNames: string[] = JSON.parse(
+  //   process.env["CODEQL_ACTION_TRACER_ENV_VAR_NAMES"] ?? "null",
+  // );
+  // if (tracerEnvVarNames !== null) {
+  //   for (const envVar of tracerEnvVarNames) {
+  //     delete process.env[envVar];
+  //   }
+  // }
+
+  delete process.env[EnvVar.DYLD_INSERT_BINARIES];
 }