Merge pull request #1313 from github/criemen/ghes-31-deprecation

GHES 3.1 has been deprecated end of June 2022.
github · Oct 18, 2022 · 3920e2d · 3920e2d
2 parents 96c8872 + f3a27d6
commit 3920e2d
Show file tree

Hide file tree

Showing 9 changed files with 4 additions and 70 deletions.
diff --git a/lib/actions-util.js b/lib/actions-util.js
diff --git a/lib/actions-util.js.map b/lib/actions-util.js.map
diff --git a/lib/util.js b/lib/util.js
diff --git a/lib/util.js.map b/lib/util.js.map
diff --git a/lib/util.test.js b/lib/util.test.js
diff --git a/lib/util.test.js.map b/lib/util.test.js.map
diff --git a/src/actions-util.ts b/src/actions-util.ts
@@ -16,7 +16,6 @@ import {
   getCodeQLDatabasePath,
   getRequiredEnvParam,
   GITHUB_DOTCOM_URL,
-  isGitHubGhesVersionBelow,
   isHTTPError,
   isInTestMode,
   UserError,
@@ -749,14 +748,6 @@ const INCOMPATIBLE_MSG =
 export async function sendStatusReport<S extends StatusReportBase>(
   statusReport: S
 ): Promise<boolean> {
-  const gitHubVersion = await api.getGitHubVersionActionsOnly();
-  if (isGitHubGhesVersionBelow(gitHubVersion, "3.2.0")) {
-    // GHES 3.1 and earlier versions reject unexpected properties, which means
-    // that they will reject status reports with newly added properties.
-    // Inhibiting status reporting for GHES < 3.2 avoids such failures.
-    return true;
-  }
-
   const statusReportJSON = JSON.stringify(statusReport);
   core.debug(`Sending status report: ${statusReportJSON}`);
   // If in test mode we don't want to upload the results

diff --git a/src/util.test.ts b/src/util.test.ts
@@ -365,33 +365,6 @@ for (const [packs, expectedStatus] of ML_POWERED_JS_STATUS_TESTS) {
   });
 }
 
-test("isGitHubGhesVersionBelow", async (t) => {
-  t.falsy(
-    util.isGitHubGhesVersionBelow({ type: util.GitHubVariant.DOTCOM }, "3.2.0")
-  );
-  t.falsy(
-    util.isGitHubGhesVersionBelow({ type: util.GitHubVariant.GHAE }, "3.2.0")
-  );
-  t.falsy(
-    util.isGitHubGhesVersionBelow(
-      { type: util.GitHubVariant.GHES, version: "3.3.0" },
-      "3.2.0"
-    )
-  );
-  t.falsy(
-    util.isGitHubGhesVersionBelow(
-      { type: util.GitHubVariant.GHES, version: "3.2.0" },
-      "3.2.0"
-    )
-  );
-  t.true(
-    util.isGitHubGhesVersionBelow(
-      { type: util.GitHubVariant.GHES, version: "3.1.2" },
-      "3.2.0"
-    )
-  );
-});
-
 function formatGitHubVersion(version: util.GitHubVersion): string {
   switch (version.type) {
     case util.GitHubVariant.DOTCOM:

diff --git a/src/util.ts b/src/util.ts
@@ -605,16 +605,6 @@ export function isHTTPError(arg: any): arg is HTTPError {
   return arg?.status !== undefined && Number.isInteger(arg.status);
 }
 
-export function isGitHubGhesVersionBelow(
-  gitHubVersion: GitHubVersion,
-  expectedVersion: string
-): boolean {
-  return (
-    gitHubVersion.type === GitHubVariant.GHES &&
-    semver.lt(gitHubVersion.version, expectedVersion)
-  );
-}
-
 let cachedCodeQlVersion: undefined | string = undefined;
 
 export function cacheCodeQlVersion(version: string): void {