Merge pull request #931 from github/henrymercer/fix-flaky-tests

Bump minimum supported CodeQL version to 2.4.5 to address flaky tests
github · Feb 17, 2022 · 6a961c0 · 6a961c0
2 parents c4e058a + db24c88
commit 6a961c0
Show file tree

Hide file tree

Showing 15 changed files with 20 additions and 17 deletions.
diff --git a/.github/workflows/__analyze-ref-input.yml b/.github/workflows/__analyze-ref-input.yml
diff --git a/.github/workflows/__debug-artifacts.yml b/.github/workflows/__debug-artifacts.yml
diff --git a/.github/workflows/__go-custom-queries.yml b/.github/workflows/__go-custom-queries.yml
diff --git a/.github/workflows/__go-custom-tracing-autobuild.yml b/.github/workflows/__go-custom-tracing-autobuild.yml
diff --git a/.github/workflows/__go-custom-tracing.yml b/.github/workflows/__go-custom-tracing.yml
diff --git a/.github/workflows/__multi-language-autodetect.yml b/.github/workflows/__multi-language-autodetect.yml
diff --git a/.github/workflows/__remote-config.yml b/.github/workflows/__remote-config.yml
diff --git a/.github/workflows/__rubocop-multi-language.yml b/.github/workflows/__rubocop-multi-language.yml
diff --git a/.github/workflows/__unset-environment.yml b/.github/workflows/__unset-environment.yml
diff --git a/.github/workflows/__upload-ref-sha-input.yml b/.github/workflows/__upload-ref-sha-input.yml
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## [UNRELEASED]
 
+- The CodeQL CLI versions up to and including version 2.4.4 are not compatible with the CodeQL Action 1.1.1 and later. The Action will emit an error if it detects that it is being used by an incompatible version of the CLI. [#931](https://github.com/github/codeql-action/pull/931)
 - Update default CodeQL bundle version to 2.8.1. [#925](https://github.com/github/codeql-action/pull/925)
 
 ## 1.1.0 - 11 Feb 2022

diff --git a/lib/codeql.js b/lib/codeql.js
diff --git a/lib/codeql.js.map b/lib/codeql.js.map
diff --git a/pr-checks/sync.py b/pr-checks/sync.py
@@ -2,8 +2,8 @@
 import os
 
 defaultTestVersions = [
-    # The oldest supported CodeQL version: 2.3.1. If bumping, update `CODEQL_MINIMUM_VERSION` in `codeql.ts`
-    "stable-20201028",
+    # The oldest supported CodeQL version: 2.4.5. If bumping, update `CODEQL_MINIMUM_VERSION` in `codeql.ts`
+    "stable-20210308",
     # The last CodeQL release in the 2.4 series: 2.4.6.
     "stable-20210319",
     # The last CodeQL release in the 2.5 series: 2.5.9.

diff --git a/src/codeql.ts b/src/codeql.ts
@@ -203,9 +203,10 @@ const CODEQL_DEFAULT_ACTION_REPOSITORY = "github/codeql-action";
  * below can be used to conditionally enable certain features on versions newer
  * than this. Please record the reason we cannot support an older version.
  *
- * Reason: Changes to how the tracing environment is set up.
+ * Reason: First version containing fix for the "We still have not reached
+ * idleness" deadlock.
  */
-const CODEQL_MINIMUM_VERSION = "2.3.1";
+const CODEQL_MINIMUM_VERSION = "2.4.5";
 
 /**
  * Versions of CodeQL that version-flag certain functionality in the Action.