Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status reporting error on Windows #1042

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Apr 25, 2022

Fixes: #1041

Status reporting currently fails on Windows because the CodeQL CLI version number retrieved by the action contains trailing \r\n line ending (so 2.8.5\r\n instead of 2.8.5). Interestingly, the reported CodeQL CLI version similarly contains \n line ending, but that for some reason did not cause server-side validation failure.

This PR fixes the bug by trimming whitespace from codeql version --format=terse output.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@cklin cklin force-pushed the windows-status-report-error branch 3 times, most recently from 958837c to 29199f4 Compare April 25, 2022 21:46
@cklin cklin changed the title Address status reporting error on Windows Fix status reporting error on Windows Apr 25, 2022
@cklin cklin marked this pull request as ready for review April 25, 2022 23:21
@cklin cklin requested a review from a team as a code owner April 25, 2022 23:21
@cklin cklin force-pushed the windows-status-report-error branch from 29199f4 to 6dd9baf Compare April 26, 2022 15:08
@cklin cklin enabled auto-merge April 26, 2022 15:09
@cklin cklin merged commit 7286114 into github:main Apr 26, 2022
@cklin cklin deleted the windows-status-report-error branch February 13, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestError [HttpError]: Invalid request.
3 participants