-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update required checks: Allow authenticating via the GitHub CLI #1138
Conversation
Maybe still keep a log warning, and a comment that this script is meant for interactive use, not as an unattended script. Otherwise in an unattended setting it will hang when it waits for you to authenticate. |
Avoid trying to evaluate `github/codeql-action`.
We no longer run this script within Actions for security reasons, and when running locally we can authenticate with the GitHub CLI instead of a PAT.
I don't really like the idea of logging warnings when everything's fine, particularly when the main use case of this script is running from a dev machine. However I can see the benefit in preventing an unattended script from hanging. I've switched to checking |
c225109
to
0a5dad3
Compare
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to leave this comment earlier.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
We no longer run this script within Actions for security reasons, and when running locally we can authenticate with the GitHub CLI instead of a PAT.
Merge / deployment checklist