Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash if we are unable to get a response from the feature-flag endpoint. #1145

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Don't crash if we are unable to get a response from the feature-flag endpoint. #1145

merged 3 commits into from
Jul 18, 2022

Conversation

criemen
Copy link
Contributor

@criemen criemen commented Jul 18, 2022 •
edited
Loading

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@criemen criemen requested a review from a team as a code owner July 18, 2022 10:15
@criemen criemen enabled auto-merge July 18, 2022 10:20
henrymercer
henrymercer approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions but otherwise looks good.

src/feature-flags.ts Show resolved Hide resolved
src/feature-flags.ts Outdated Show resolved Hide resolved
@criemen criemen disabled auto-merge July 18, 2022 10:37
@criemen criemen requested a review from henrymercer July 18, 2022 10:37
henrymercer
henrymercer approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@criemen criemen enabled auto-merge July 18, 2022 10:39
@criemen criemen merged commit ba95eeb into main Jul 18, 2022
@criemen criemen deleted the criemen/fix-ff-crash branch July 18, 2022 12:04
@github-actions github-actions bot mentioned this pull request Jul 21, 2022
Closed
6 tasks
This was referenced Jul 28, 2022
Merged
Merged
This was referenced Apr 25, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoardopirovano edoardopirovano edoardopirovano approved these changes

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@criemen @edoardopirovano @henrymercer