Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expect-error input to force PR check green on expected failure #1177

Merged
merged 22 commits into from
Aug 16, 2022
Merged

Add expect-error input to force PR check green on expected failure #1177

merged 22 commits into from
Aug 16, 2022

Commits on Aug 12, 2022

  1. Add expect-error to expected failure job check

    @angelapwen
    angelapwen committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    b7d4497 View commit details
    Browse the repository at this point in the history

  2. Remove "failure expected" in PR check name

    @angelapwen
    angelapwen committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    4fb1cdc View commit details
    Browse the repository at this point in the history

  3. Update expect-errors input description 

    Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
    @angelapwen @aeisenberg
    angelapwen and aeisenberg authored Aug 12, 2022
    Configuration menu
    Copy the full SHA
    c756bae View commit details
    Browse the repository at this point in the history

  4. Add double quotes to input description

    @angelapwen
    angelapwen committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    59d39e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Throw error if caller isn't codeql-action

    @angelapwen
    angelapwen committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    f5a4ea9 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into angelapwen/expect-err… 

    …or-input
    @angelapwen
    angelapwen committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    14763b6 View commit details
    Browse the repository at this point in the history

  3. Fix string equality comparison

    @angelapwen
    angelapwen committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    e31c33d View commit details
    Browse the repository at this point in the history

  4. Move error throwing location

    @angelapwen
    angelapwen committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    46f3540 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Add print debug messages

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    3606edb View commit details
    Browse the repository at this point in the history

  2. Fix expected repo URL

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    334b121 View commit details
    Browse the repository at this point in the history

  3. Set failure if input is set incorrectly

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    65fcacd View commit details
    Browse the repository at this point in the history

  4. Update expect-errors input description 

    Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
    @angelapwen @aeisenberg
    angelapwen and aeisenberg authored Aug 16, 2022
    Configuration menu
    Copy the full SHA
    3d8828a View commit details
    Browse the repository at this point in the history

  5. Address comments, throw failure if expected and didn't fail

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    6be3892 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into angelapwen/expect-err… 

    …or-input
    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    0736537 View commit details
    Browse the repository at this point in the history

  7. Set failure in other spot for expect-error but not thrown

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    1e1da28 View commit details
    Browse the repository at this point in the history

  8. Test removing runWrapper's failure

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    66bfa45 View commit details
    Browse the repository at this point in the history

  9. Check error input is not default value

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    70d3299 View commit details
    Browse the repository at this point in the history

  10. Test remove runWrapper setting failure

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    41f86d9 View commit details
    Browse the repository at this point in the history

  11. Test run where error expected but not received

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    5aec66f View commit details
    Browse the repository at this point in the history

  12. Fail with ram:1 in failure workflow

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    98d4d17 View commit details
    Browse the repository at this point in the history

  13. Comment fixups

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    f8f36a7 View commit details
    Browse the repository at this point in the history

  14. Remove extraneous log lines

    @angelapwen
    angelapwen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    b67600f View commit details
    Browse the repository at this point in the history