-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable bypassing the cached CodeQL bundle via a feature flag #1185
Conversation
da8b28b
to
e1cd41a
Compare
Could we get |
Hmm, we could modify the workflow generator to look for patterns like We have one workflow that explicitly doesn't set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for doing a bit of drive-by cleaning up on the code as well 👍🏼
I'll hold off on merging this until we've deployed the feature flag and I can do a final manual test in our internal testing org. |
Manual testing ✅ |
In the case that a broken bundle makes its way through the release process, and we only make a rollback decision after that bundle has already made it into the toolcache, this gives us a mechanism to easily perform that rollback in a timely way. See the internal issue for more details.
Merge / deployment checklist