Make Go a traced language when Go extraction reconciliation is enabled #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the test depended on `createdDBForScannedLanguages` making no async calls prior to `codeql resolve extractor`.
Now the test is fixed, we can simplify by introducing an async call.
We now trace in init when using reconciled tracing, so we no longer need to set the `CODEQL_EXTRACTOR_GO_BUILD_TRACING` environment variable.
aeisenberg
reviewed
Sep 2, 2022
aeisenberg
approved these changes
Sep 2, 2022
aeisenberg
approved these changes
Sep 2, 2022
This was referenced Sep 14, 2022
This was referenced Apr 24, 2023
This was referenced Apr 24, 2023
This was referenced Jun 25, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1219.
This PR treats Go as a traced language when the beta support for Go extraction reconciliation is enabled (either via an environment variable, for use in testing, or via the feature flag). This has the effect of enabling tracing in
init(and disabling it inanalyze) when Go extraction reconciliation is enabled.We add two PR checks to ensure that Go extraction works as expected for workflows with an autobuild step and workflows with custom build steps, in addition to the existing PR check from #1219 relating to (to be) legacy workflows with neither an autobuild step nor custom build steps.
Merge / deployment checklist