-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Lua tracing for Go on Windows in CLI 2.10.4+ #1229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug preventing us from using Lua tracing for Go on Windows is fixed in CLI 2.10.4+, so we can now resume using Lua tracing for Go on Windows when using these CLI versions.
cklin
approved these changes
Sep 1, 2022
This was referenced Sep 14, 2022
This was referenced Apr 24, 2023
This was referenced Apr 24, 2023
This was referenced Apr 25, 2023
This was referenced Apr 25, 2023
This was referenced Apr 26, 2023
This was referenced Jun 25, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug preventing us from using Lua tracing for Go on Windows (see #1209) is fixed in CLI 2.10.4+, so we can now resume using Lua tracing for Go on Windows when using these CLI versions.
Merge / deployment checklist