TRAP Caching: Be tolerant to not finding the extractor #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
approved these changes
Sep 5, 2022
edoardopirovano
force-pushed
the
edoardo/more-tolerant
branch
from
c2dc6ac
to
299b774
Compare
This was referenced Sep 14, 2022
This was referenced Jun 22, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also github/codeql#10292
In some internal use-cases where we hack in an extra extractor by adding a
--search-pathto various CLI calls, we may not actually find it in this CLI call if the--search-pathhasn't been added in. Since TRAP caching is non-essential, let's be tolerant here and just skip languages whose extractor we fail to find.Merge / deployment checklist