Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions status report: Send testing_environment. #1321

Merged
merged 4 commits into from
Nov 1, 2022
Merged

Conversation

criemen
Copy link
Contributor

@criemen criemen commented Oct 25, 2022

The testing environment is taken from the environment variable CODEQL_ACTION_TESTING_ENVIRONMENT.

I guess the main question for the reviewers is if the environment variable should be set again using the actions environment mechanism to preserve it for future steps.
But I think we get away with a top-level env block, or a per-job env entry that we can use.

CC @esbena

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@criemen criemen requested a review from a team as a code owner October 25, 2022 13:31
henrymercer
henrymercer previously approved these changes Oct 25, 2022
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the main question for the reviewers is if the environment variable should be set again using the actions environment mechanism to preserve it for future steps.

I like this idea — it sounds like this would be one line of code that could prevent some headaches.

The testing environment is taken from the environment variable
CODEQL_ACTION_TESTING_ENVIRONMENT.
@criemen
Copy link
Contributor Author

criemen commented Nov 1, 2022

Rebased on top of main and added the call to exportVariable.

henrymercer
henrymercer previously approved these changes Nov 1, 2022
src/actions-util.ts Outdated Show resolved Hide resolved
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@criemen criemen merged commit 72bd9cb into main Nov 1, 2022
@criemen criemen deleted the criemen/datadog-tag branch November 1, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants