-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge releases/v2 into releases/v1 #1377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now only need to support doing this in the CLI.
It is 2.8.2, not 2.7.3.
Mergeback v2.1.32 refs/heads/releases/v2 into main
This is now covered by `codescanning-config-cli.yml`.
These are covered by `codeql.yml`, which runs across all latest runner images.
These are tested by `multi-language-autodetect.yml`
These are covered by `autobuild-action.yml`.
Testing SARIF compatibility is covered by `codeql.yml`.
We don't need to test runner functionality now since the runner is only used in PR checks, and `extractor-ram-threads.yml` covers the Action case.
Co-authored-by: Henry Mercer <henry.mercer@me.com>
We could move everything into `util`, but in some ways it is nice having a file dedicated to Actions related utilities.
…CTOR_GO_BUILD_TRACING` for custom builds (#1322) Co-authored-by: Henry Mercer <henry.mercer@me.com>
Delete the runner, part 2
Given that the GITHUB_REF is a protected variable, we want to prefer it to CODE_SCANNING_REF. This should prevent accidentally overwriting these values. The logic is a bit more involved, as I think it makes sense to raise the error about GITHUB_REF not being set, rather than mentioning CODE_SCANNING_REF if both are not set.
Bump minimum CodeQL bundle version to 2.6.3
Prefer GITHUB_REF to CODE_SCANNING_REF
Merge main into releases/v2
This reverts commit b3d9a91.
This reverts commit f71b2a3.
…-678fc3af # Conflicts: # package-lock.json
marcogario
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging 678fc3a into releases/v1
Conductor for this PR is @marcogario.
Contains the following pull requests:
CODEQL_EXTRACTOR_GO_BUILD_TRACING
for custom builds #1322 (@angelapwen)Please do the following:
package.json
file contains the correct version.package-lock.json
Create a merge commit
is selected rather thanSquash and merge
orRebase and merge
.