-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up the Swift version the extractor declares #1422
Conversation
I can conditionally setup 5.7.0 for |
For I think perhaps while Swift is in beta, we should just test that the Swift extractor is compatible with the Swift version it declares:
This mimics the internal tests, and while it's further away from customer setups, it avoids us having to update these tests every release while Swift is in beta. |
Oh, that's a nice workaround. Updated 👍 (although I guess the internal tests should also be testing prior versions of Swift to catch problems similar to the one we just encountered) |
Ah, that approach isn't very easy because we need to setup Swift before running In that case, we might have to stop running this test on Optionally, we could define a top-level |
I've updated all 4 Swift-related PR checks to use 5.7.1, and stopped testing
Is it a viable solution to just wait until the newest CLI version that supports 5.7.1 makes it into |
Aditya suggested checking the Swift version from the extractor after the |
I think the above approach should work, but we are still getting this error —
Is this perhaps the wrong path, or has the extractor been cleaned up after the |
9c925fc
to
2c0ca85
Compare
2c0ca85
to
20b2d99
Compare
8531eee
to
3c9bc73
Compare
79f629c
to
4f1c8c5
Compare
Hmm, this is a little annoying. I think the problem is that the
I expect that if we replace the call by |
Thank you — that did it! That makes sense 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible, good work! Minor Bash suggestions.
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
Hm... the PR checks I changed don't seem to have run anymore. I'll close and reopen to see if this triggers them. EDIT: Could be that the file path should be |
Ok.. that seems to have done it 😆 re-requesting review (again), sorry! |
This PR changes the
setup-swift
Action to set up the version of Swift the extractor declares (except on Windows). It also adds thenightly-latest
PR check back to a couple of PR checks, which were removed in #1412 to unblock the release.Note that after this PR merges, we should remember to update the corresponding integration test within the CLI, and include the bumped
setup-swift
SHA (#1415) as well.When the newest version of the CLI (that supports 5.7.1) makes it to
latest
andcached
, we should be able to remove this logic and unconditionally setup 5.7.1, as future versions of the extractor should maintain backwards compatibility with prior Swift versions.Merge / deployment checklist