-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send tools telemetry to init
status report
#1497
Conversation
a9545a6
to
f24d78c
Compare
init
status report
a217825
to
4fa58ed
Compare
Looks like a bit of an inscrutable error, Also, oddly enough the error fails in the |
I think this could be as boring as just needing to merge in main and recompile the Action — some of the compiled files seem to be missing at the moment. |
…n/codeql-action into tools-telemetry-report
I have an issue with |
8ca90f9
to
919c531
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you've used this additional telemetry information to improve the tests for setting up the CodeQL tools! Here's a couple of initial comments:
I think I've addressed all comments and PR is ready for review again! |
Co-authored-by: Henry Mercer <henry.mercer@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! A couple of minor suggestions to improve the types, and there are a few conflicts to resolve before we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This PR sends the following fields to the
init
status report on success and failure:tools_source
tools_source
wasDOWNLOAD
,tools_download_duration_ms
andtools_feature_flags_valid
Note that previously we only sent additional fields on
init
success, but because we would like to support the tools fields on failure as well, the PR changes the status report behavior so that theinit
report is sent on failure too, with as many fields populated as possible.Merge / deployment checklist