Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail prepare-test early when gh release list fails #1506

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fail prepare-test early when gh release list fails #1506

merged 1 commit into from
Jan 23, 2023

Conversation

henrymercer
Copy link
Contributor

We've been seeing some tests fail recently due to the gh release list command failing. Because Bash doesn't fail on error by default, those errors weren't manifesting themselves until a later step. This PR adds set -e so the prepare-test Action fails straight away. This makes it slightly quicker to triage the error and saves a bit of runner time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner January 23, 2023 19:14
angelapwen
angelapwen approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the drive by fixes ✨

@henrymercer henrymercer merged commit 14c4412 into main Jan 23, 2023
@henrymercer henrymercer deleted the henrymercer/prepare-test-fail-early branch January 23, 2023 19:39
@github-actions github-actions bot mentioned this pull request Jan 26, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @angelapwen