Fall back to the defaults.json CLI version if feature flags misconfigured
#1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect at least one default CLI version to be enabled on Dotcom at any time. However if the feature flags are misconfigured, rather than crashing, we fall back to the CLI version shipped with the Action in defaults.json. This has the effect of immediately rolling out new CLI versions to all users running the latest Action.
A drawback of this approach relates to the small number of users that run old versions of the Action on Dotcom. As a result of this approach, if we misconfigure the feature flags then these users will experience some alert churn. This is because the CLI version in the defaults.json shipped with an old version of the Action is likely older than the CLI version that would have been specified by the feature flags before they were misconfigured.
Merge / deployment checklist