Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --qlconfig-file option #1564

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Fix --qlconfig-file option #1564

merged 3 commits into from
Mar 7, 2023

Conversation

aeisenberg
Copy link
Contributor

Fixes an invalid CLI option being passed to database init.

@aeisenberg aeisenberg requested a review from a team as a code owner March 7, 2023 16:40
@aeisenberg aeisenberg mentioned this pull request Mar 7, 2023
3 tasks
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple more bugs I fixed in the bundle update branch. Would you consider cherry-picking a6d3a44, 100bd7b, and eb40427?

src/codeql.test.ts Outdated Show resolved Hide resolved
@aeisenberg
Copy link
Contributor Author

Sure.

@aeisenberg aeisenberg force-pushed the aeisenberg/qlconfig-file branch from 8af7c45 to c310f09 Compare March 7, 2023 16:47
@henrymercer
Copy link
Contributor

@angelapwen Would you mind taking a quick look? It's Andrew's PR and my commits, so neither of us can review 😆

Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look straightforward ✅

@aeisenberg aeisenberg merged commit e4b846c into main Mar 7, 2023
@aeisenberg aeisenberg deleted the aeisenberg/qlconfig-file branch March 7, 2023 21:15
@github-actions github-actions bot mentioned this pull request Mar 10, 2023
6 tasks
mirabilos added a commit to mirabilos/mksh that referenced this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants