-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into releases/v2 #1608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mergeback v2.2.8 refs/heads/releases/v2 into main
…g-override Add override for code scanning analysis of default branch
- The `upload` input to the `analyze` Action now accepts the following values: - `always` is the default value, which uploads the SARIF file to Code Scanning for successful and failed runs. - `failure-only` is recommended for customers post-processing the SARIF file before uploading it to Code Scanning. This option uploads debugging information to Code Scanning for failed runs to improve the debugging experience. - `never` avoids uploading the SARIF file to Code Scanning even if the code scanning run fails. This is not recommended for external users since it complicates debugging. - The legacy `true` and `false` options will be interpreted as `always` and `failure-only` respectively. --------- Co-authored-by: Henry Mercer <henry.mercer@me.com>
Only tests the property we are looking for and avoids problems with different cross-platform behavior.
…-workaround Work around duplicate locations bug in diagnostics export
henrymercer
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging fb32c3f into releases/v2.
Conductor for this PR is @henrymercer.
Contains the following pull requests:
upload
input values and logic #1598 (@angelapwen)Please do the following:
Create a merge commit
is selected rather thanSquash and merge
orRebase and merge
.