Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bundleVersion field set by the automated bundle update PR #1652

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

henrymercer
Copy link
Contributor

The bundleVersion is the whole tag, we don't want to remove the codeql-bundle- prefix.

Commit-by-commit review recommended since we autoformat the update bundle Action in the second commit.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

It's the whole tag, we don't want to remove the `codeql-bundle-` prefix.
@henrymercer henrymercer requested a review from a team as a code owner April 18, 2023 18:01
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 how long has this been broken for? 😬

@henrymercer
Copy link
Contributor Author

Not long — 2.12.7 was the first automated bundle upgrade PR, since the trigger wasn't working for 2.13.0 (#1648). Hopefully we're over the teething pains now!

@henrymercer henrymercer merged commit afdf30f into main Apr 18, 2023
@henrymercer henrymercer deleted the henrymercer/fix-bundle-version branch April 18, 2023 20:04
@angelapwen
Copy link
Contributor

since the trigger wasn't working for 2.13.0

💡 that'll do it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants