Respect scaling_reserved_ram feature flag
#1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
reviewed
Jul 7, 2023
There was a problem hiding this comment.
Looks good. It's perhaps a little cautious, but we might want to add an integration test that runs the CodeQL Action with this feature enabled. To do so, we could make a copy of pr-checks/checks/multi-language-autodetect.yml, enable the feature flag via the environment variable, and remove the language autodetection checks.
|
Oh, do add a changelog note too! The one from 24th May is a good example. |
The amount of RAM given to the CodeQL evaluator is the machine's total memory size, minus a reserved amount. Currently, the reserved amount is fixed at 1 GB (or 1.5 GB on Windows). When the scaling_reserved_ram feature flag is enabled, we also add 2% of the total memory size to the reserved amount. This allows for the fact that the kernel will consume more RAM (e.g. for page tables) on machines with more physical RAM.
nickrolfe
force-pushed
the
nickrolfe/scaling-memory
branch
2 times, most recently
from
e392b54
to
6b7e394
Compare
nickrolfe
force-pushed
the
nickrolfe/scaling-memory
branch
from
6b7e394
to
ab9aa50
Compare
|
I see the new integration test is running with |
henrymercer
approved these changes
Jul 7, 2023
|
Whoops, yes, that's what I meant. |
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of RAM given to the CodeQL evaluator is the machine's total memory size, minus a reserved amount.
Currently, the reserved amount is fixed at 1 GB (or 1.5 GB on Windows). When the
scaling_reserved_ramfeature flag is enabled, we also add 2% of the total memory size to the reserved amount. This allows for the fact that the kernel will consume more RAM (e.g. for page tables) on machines with more physical RAM, so we should see fewer analyses getting killed by the OOM killer.N.B. This is my first time working on the Action, or even writing TypeScript. I hope my uses of
async/awaitmake sense.Merge / deployment checklist