-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the no code found URL #1779
Conversation
Also someone with the right access should fix this too (I can't see the instructions, unsurprisingly): |
Thank you for your contribution @peternewman! The repository uses TypeScript transpiled into Javascript: could you update the TypeScript file at We'll look into updating the link in the official documentation as well — thanks again 💖 |
Hello! I've just been reminded that we are using a new shortlink — https://gh.io/troubleshooting-code-scanning/no-source-code-seen-during-build (the one referenced in the documentation) — which will allow us to avoid this problem in the future, as the link will handle the case where the docs URL changes in the future. Do you mind updating to this link as well? Thanks! |
Everything looks good, you'll just need to run the build command again to regenerate the transpiled files to pass the failing PR check!
|
Do you want a changelog entry for this?
Oops, I think I'd found that first during the code search, then edited the wrong file!
Excellent thanks.
Even better!
Yeah I was just waiting until I was in front of a proper machine not just doing it in a web browser! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't need a changelog entry here as we generally don't add one if we're just updating documentation — thank you for checking though!
I've approved the checks to run again 😸
The failing checks are unrelated to your PR. We'll work on resolving them, please hold tight 😄 |
It looks like it's all green now @angelapwen Perhaps you should have enabled automerge! 😄 |
Ha, I was thinking that perhaps you'd want the pleasure of clicking the merge button 😆 I'll merge now! Thank you again 💖 |
I don't think I remember seeing it, and I don't think I'd expect to unless you've given me more rights to the repo than a normal user. |
Merge / deployment checklist