Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve cyclic imports #1794

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Resolve cyclic imports #1794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bf162c4
Enable no cyclic dependencies eslint rule
henrymercer Jul 19, 2023
9922e17
Move code scanning config enablement into feature flags
henrymercer Jul 19, 2023
d577d6f
Resolve dependency cycle between util and API client
henrymercer Jul 19, 2023
004f976
Fix dependency cycle between util and config-utils
henrymercer Jul 19, 2023
0bc4788
Resolve dependency cycle between `api-client` and `actions-util`
henrymercer Jul 19, 2023
2637069
Resolve dependency cycles between `actions-util` and `workflow`
henrymercer Jul 19, 2023
5658fd1
Fix dependency cycle between trap-caching and init
henrymercer Jul 19, 2023
bac7c32
Resolve the final dependency cycle!
henrymercer Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
}],
"import/no-amd": "error",
"import/no-commonjs": "error",
"import/no-cycle": "error",
"import/no-dynamic-require": "error",
// Disable the rule that checks that devDependencies aren't imported since we use a single
// linting configuration file for both source and test code.
Expand Down
234 changes: 31 additions & 203 deletions lib/actions-util.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading