Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin: CodeQL >= 2.13.4 supports 1.9.10. #1853

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Kotlin: CodeQL >= 2.13.4 supports 1.9.10. #1853

merged 7 commits into from
Aug 24, 2023

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Aug 24, 2023

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@igfoo igfoo requested a review from a team as a code owner August 24, 2023 13:58
henrymercer
henrymercer previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a changelog note along the lines of "Enable support for Kotlin 1.9.20 when running with CodeQL CLI v2.13.4"

@igfoo
Copy link
Contributor Author

igfoo commented Aug 24, 2023

Done. I also realised that we also want an upper limit on the codeql version, or this will start having the opposite to the desired effect at some point in the future.

@igfoo igfoo merged commit ff9cb43 into main Aug 24, 2023
344 checks passed
@igfoo igfoo deleted the igfoo/kot1.9.10 branch August 24, 2023 18:10
@github-actions github-actions bot mentioned this pull request Aug 28, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igfoo @henrymercer