-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a fix for python 3.12 #1928
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
name: Test that the workaround for python 3.12 on windows works | ||
|
||
on: | ||
push: | ||
branches: [main, releases/v2] | ||
pull_request: | ||
# Run checks on reopened draft PRs to support triggering PR checks on draft PRs that were opened | ||
# by other workflows. | ||
types: [opened, synchronize, reopened, ready_for_review] | ||
schedule: | ||
# Weekly on Monday. | ||
- cron: '0 0 * * 1' | ||
workflow_dispatch: | ||
|
||
jobs: | ||
test-setup-python-scripts: | ||
timeout-minutes: 45 | ||
runs-on: windows-latest | ||
|
||
steps: | ||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: 3.12 | ||
|
||
- uses: actions/checkout@v4 | ||
|
||
- name: Prepare test | ||
uses: ./.github/actions/prepare-test | ||
with: | ||
version: default | ||
|
||
- name: Initialize CodeQL | ||
uses: ./../action/init | ||
with: | ||
tools: latest | ||
languages: python | ||
|
||
- name: Analyze | ||
uses: ./../action/analyze | ||
with: | ||
upload-database: false |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,19 @@ | ||||||
|
||||||
#! /usr/bin/pwsh | ||||||
|
||||||
# If we are running greater than or equal to python 3.12, change py to run version 3.11 | ||||||
Write-Host "Checking python version" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Super-nit There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, I think all |
||||||
if ((py -3 -c "import sys; print(0 if sys.version_info >= (3, 12) else 1)") -eq "0") { | ||||||
Write-Host "python 3.12+ detected, setting PY_PYTHON3=3.11" | ||||||
# First make sure we have python 3.11 installed | ||||||
py -3.11 -c "import imp" | ||||||
if ($LASTEXITCODE -eq 0) { | ||||||
Write-Host "python 3.11 detected, using this version instead of 3.12+." | ||||||
Write-Output "PY_PYTHON3=3.11" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append | ||||||
} else { | ||||||
Write-Host "FAILURE: Python 3.12+ is not supported, and Python 3.11 could not be detected on the system. Please install Python 3.11." | ||||||
exit 1 | ||||||
} | ||||||
} else { | ||||||
Write-Host "python 3.12+ not detected, not making any changes." | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized it's missing a word..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I'll put this in a follow-up.