Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Go path warning unconditional #1946

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Make Go path warning unconditional #1946

merged 2 commits into from
Oct 13, 2023

Conversation

mbg
Copy link
Member

@mbg mbg commented Oct 13, 2023

This modifies the warning/diagnostic we added in #1909 to be unconditional on whether or not we installed the workaround.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@mbg mbg self-assigned this Oct 13, 2023
@mbg mbg marked this pull request as ready for review October 13, 2023 14:50
@mbg mbg requested a review from a team as a code owner October 13, 2023 14:50
@mbg mbg merged commit d859d17 into main Oct 13, 2023
659 checks passed
@mbg mbg deleted the mbg/unconditioal-go-warning branch October 13, 2023 15:37
@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees

@mbg mbg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbg @henrymercer