Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error in Update release branch workflow #2051

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

angelapwen
Copy link
Contributor

Simply casts a string to an int 😸

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen requested a review from a team as a code owner December 21, 2023 21:39
@@ -46,7 +46,7 @@ def main():
if consider_backports:
for i in range(int(major_version.strip("v"))-1, 0, -1):
branch_name = f"releases/v{i}"
if i >= OLDEST_SUPPORTED_MAJOR_VERSION:
if i >= int(OLDEST_SUPPORTED_MAJOR_VERSION):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only use of this variable so it works; the more durable option would be to typecast at the definition of OLDEST_SUPPORTED_MAJOR_VERSION.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's fair — I had thought it might be easier to explicitly cast when used but I guess we'd always be using it as an int. I'll update.

@adityasharad adityasharad merged commit 40cb08c into main Dec 21, 2023
339 checks passed
@adityasharad adityasharad deleted the angelapwen/patch-release-script branch December 21, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants