Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths/paths-ignore warning that would appear unconditionally #2080

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

henrymercer
Copy link
Contributor

This warning should only appear on traced languages if the user has configured paths or paths-ignore, however it was appearing unconditionally. This is because undefined?.length !== 0 evaluates to true.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner January 11, 2024 11:56
tamasvajk
tamasvajk previously approved these changes Jan 11, 2024
Copy link

@tamasvajk tamasvajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrymercer henrymercer merged commit eb14aeb into main Jan 11, 2024
317 checks passed
@henrymercer henrymercer deleted the henrymercer/fix-unconditional-warning branch January 11, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants