Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow omitting the autobuild Action when build mode specified #2120

Merged

Conversation

henrymercer
Copy link
Contributor

This PR enables users to omit the autobuild Action when the build mode is specified and the CLI supports the traceCommandUseBuildMode feature (available in CodeQL CLI 2.16.2 and later). This will remove redundancy and reduce the possibility for errors.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner February 7, 2024 13:31
angelapwen
angelapwen previously approved these changes Feb 7, 2024
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I like how simple that test was 💖

src/analyze.ts Show resolved Hide resolved
@henrymercer henrymercer force-pushed the henrymercer/no-autobuild-action-necessary-with-build-mode branch from 3bd00e8 to f3ced61 Compare February 8, 2024 16:00
@henrymercer
Copy link
Contributor Author

@angelapwen I added a couple more tests for the other build modes. Would you mind taking another look?

Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tests look good to me! Should this have a changelog note? Or will we wait for a general larger-scale announcement of the new build modes?

@henrymercer
Copy link
Contributor Author

Right now, this is just for internal testing. Once we've finished testing, we can remove all the internal labels and add a changelog note with all the changes.

@henrymercer henrymercer merged commit fc9f9e5 into main Feb 8, 2024
303 checks passed
@henrymercer henrymercer deleted the henrymercer/no-autobuild-action-necessary-with-build-mode branch February 8, 2024 16:23
@github-actions github-actions bot mentioned this pull request Feb 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants