Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the --sarif-include-query-help option when supported #2191

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

henrymercer
Copy link
Contributor

This avoids a deprecation warning appearing in the logs.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner March 11, 2024 18:33
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion.


async function getCodeScanningQueryHelpArguments(
codeql: CodeQL,
): Promise<string[]> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: This can return Promise<string> and the use above can remove the ....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, but there's also something to be said for having these helper functions consistently return string[] 🤔 I think I'll leave as is.

@henrymercer henrymercer merged commit 69e120d into main Mar 11, 2024
297 checks passed
@henrymercer henrymercer deleted the henrymercer/use-include-query-help-flag branch March 11, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants