Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail more clearly if the file program is not installed on the runner #2234

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Fail more clearly if the file program is not installed on the runner #2234

merged 10 commits into from
Apr 15, 2024

Commits on Apr 11, 2024

  1. Produce a clearer error message when file is not installed

    @mbg
    mbg committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8ea1a11 View commit details
    Browse the repository at this point in the history

  2. Emit diagnostic if file is not installed

    @mbg
    mbg committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1829b70 View commit details
    Browse the repository at this point in the history

  3. Add integration test for new diagnostic

    @mbg
    mbg committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    96f44cb View commit details
    Browse the repository at this point in the history

  4. Check that the database exists before writing diagnostics to it

    @mbg
    mbg committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d4e7b0e View commit details
    Browse the repository at this point in the history

  5. Store diagnostics in memory until the database is available

    @mbg
    mbg committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    4b0172d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Unify error messages in getFileType

    @mbg
    mbg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3901d12 View commit details
    Browse the repository at this point in the history

  2. Unconditionally report unwritten diagnostics at the end of the init… 

    … Action
    @mbg
    mbg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1ac88f3 View commit details
    Browse the repository at this point in the history

  3. Include "Linux" in diagnostic name and message

    @mbg
    mbg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    93f93fc View commit details
    Browse the repository at this point in the history

  4. Downgrade log levels for some messages to debug

    @mbg
    mbg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    efc4746 View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @mbg
    mbg committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4fcf7a2 View commit details
    Browse the repository at this point in the history