Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End tracing in autobuild Action for workflows that don't specify a build mode #2282

Merged
merged 2 commits into from
May 10, 2024

Conversation

henrymercer
Copy link
Contributor

This lets us achieve some performance and reliability improvements for workflows that run autobuild directly without specifying a build mode.

Also don't call trace-command for workflows that don't specify a build mode as the indirect tracer will already have been started in these cases.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

…liability

This lets us achieve some performance and reliability improvements for
workflows that run autobuild directly without specifying a build mode.
@henrymercer henrymercer requested a review from a team as a code owner May 9, 2024 14:09
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The additional log message about unsetting the tracing environment variables will be helpful 👍

@henrymercer henrymercer merged commit 4995c49 into main May 10, 2024
320 checks passed
@henrymercer henrymercer deleted the henrymercer/no-build-mode-tracing-improvements branch May 10, 2024 09:15
@github-actions github-actions bot mentioned this pull request May 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants