Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable fail-fast for PR checks #2283

Merged
merged 2 commits into from
May 10, 2024
Merged

Disable fail-fast for PR checks #2283

merged 2 commits into from
May 10, 2024

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented May 10, 2024 •
edited

We have found fail-fast has been getting in the way more than it's been helping recently. For example:

  • Sometimes only a particular set of versions or OSes are broken, and we want to let the other checks complete so we can know the full set.
  • We see quite a large degree of parallelism when running the checks, so most of the jobs have nearly finished anyway when they are cancelled by fail-fast.
  • fail-fast deals better with transient failures.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner May 10, 2024 15:34
aeisenberg
aeisenberg approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏩

@henrymercer henrymercer merged commit a8c32fd into main May 10, 2024
320 checks passed
@henrymercer henrymercer deleted the henrymercer/disable-fail-fast branch May 10, 2024 16:28
@github-actions github-actions bot mentioned this pull request May 13, 2024
Merged
8 tasks
@henrymercer henrymercer mentioned this pull request May 13, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henrymercer @aeisenberg