Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steady_state_default_setup as field to base status report #2305

Merged
merged 1 commit into from
May 22, 2024

Conversation

angelapwen
Copy link
Contributor

@angelapwen angelapwen commented May 22, 2024

This will help us distinguish steady-state runs in default setup mode from advanced setup runs and default setup validation/onboarding runs.

The environment variable will be set accordingly in code scanning.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen marked this pull request as ready for review May 22, 2024 20:28
@angelapwen angelapwen requested a review from a team as a code owner May 22, 2024 20:28
This will help us distinguish steady-state runs in default setup mode from advanced setup runs and default setup validation/onboarding runs.
@angelapwen angelapwen force-pushed the angelapwen/add-steady-state-status-report branch from a1abd0d to 4f7eb81 Compare May 22, 2024 20:39
@@ -270,6 +272,8 @@ export async function createStatusReportBase(
if (testingEnvironment !== "") {
core.exportVariable(EnvVar.TESTING_ENVIRONMENT, testingEnvironment);
}
const isSteadyStateDefaultSetupRun =
process.env["CODE_SCANNING_IS_STEADY_STATE_DEFAULT_SETUP"] === "true";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably, this env var is set in the dynamic workflow when appropriate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I will tag you on the internal PR for it 😄

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Assuming the answer to my question is "yes".

@angelapwen angelapwen merged commit acdf238 into main May 22, 2024
296 checks passed
@angelapwen angelapwen deleted the angelapwen/add-steady-state-status-report branch May 22, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants