-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Checks: Use tools: linked
rather than tools: latest
#2320
Conversation
Also changes the input and output in the `prepare-test` Action to use `linked`.
2d5d2ad
to
67d5a9a
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
3b0d213
to
67d5a9a
Compare
I think this is happening because we renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks comprehensive to me, thank you for your effort cleaning this up.
I have a couple of questions (minor, so not to hold up this PR from getting merged):
- Is there any way for us to know if we have forgotten any places where this should be sustituted, save for doing a whole source-root
grep
? - If we have forgotten anything, my understanding is that the impact is going to be low, given the intentional backwards compatibility in the change. Is this still deemed accurate, or am I missing something that requires greater precision in the change?
Thanks for the review!!
I also just
That's still accurate! I just saw the warnings when I was checking the logs of some PR checks and thought it would be best to switch over. The |
As of #2281, we introduced
linked
as a more descriptive value for thetools
input. This PR updates our own PR checks and workflows with the new value and changes the input/output in theprepare-test
Action to uselinked
.All of the required PR checks that had
latest
in their names, formain
have been updated. As we releasev3
andv2
we'll want to do the same for those branches.Merge / deployment checklist