Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude push-only unit tests job from required PR checks script #2409

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Aug 5, 2024

The "Check JS" job and "Unit Test" job are both in the same workflow. On push, we run the "Check JS" job but skip the "Unit Test" run to save compute. This results in a skipped (non-matrixed) "Unit Test" job. This PR makes sure that that "Unit Test" job doesn't get included in the required checks for main and the release branches, which we maintain via a script.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner August 5, 2024 19:38
@henrymercer henrymercer merged commit 441c9d9 into main Aug 6, 2024
312 checks passed
@henrymercer henrymercer deleted the henrymercer/fix-required-checks branch August 6, 2024 12:50
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants